-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes global narration use tgui inputs and look pretty. #5057
Conversation
I find it particularly ironic that I posted a PR that mentions sending text before it was ready with an ENTER keypress with half of its description not written. Anyway, I think its all there now. |
Co-authored-by: harryob <[email protected]>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Merge master let the css file regenerate
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
My github seems to be drunk. |
Okay this is hilalrously broken, I'll reopen it when the bigger MR I have that touches the same files goes in. |
Not reopening this since its already in my downstream, but just in case the diff to copy to make this work is at e232323 |
About the pull request
This pr makes all global narrate inputs use tgui, adds an optional header line, better formatting and a clear color. Global Narration uses the Info tag.
On the latter point: I tried to make it use the blue it uses right now, but the text looked drab and didn't stand out at all. Once again, since I display walls of text in my downstream I've had some time to fiddle with this, but throw me any hex value and I'll slap them in instead at will. Also, it technically can be changed with proper tags, but I'd rather admins stick to paragraph tags.
tgui multiline inputs properly catch new lines and SHIFT-ENTER keypresses, enter however is just a confirmation so beware, due to how tgui input works, you will sent the message if you just push enter.
You may be noticing a trend with these upstream pushes now ;P
May conflict with #5048 because they both tyouch the style csses, but its a quick fix should that happen.
Explain why it's good for the game
tgui mutiline inputs for IC narration and the text being properly styled are, well, good because they look good and are easier to read/notice.
Also something something text heavy donwstream.
There is a lot to be said about in general presenting text you want to be read in ways that make it readable, like the colors and formatting/styling and this is part of what I'm trying to do to make the text outputs less opressive.
Testing Photographs and Procedure
Screenshots & Videos
DARK MODE
LIGHT MODE
Changelog
🆑silencer_pl
admin: narrate to everyone now has an optional header, uses multiline tgui inputs and is presented in a better, clearer fashion.
/:cl: